Skip to content

core::rand shouldn't used boxed traits #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Oct 2, 2012 · 2 comments
Closed

core::rand shouldn't used boxed traits #3640

brson opened this issue Oct 2, 2012 · 2 comments

Comments

@brson
Copy link
Contributor

brson commented Oct 2, 2012

Right now the constructors return Rng types, but they probably shouldn't.
@Dretch
Copy link
Contributor

Dretch commented Oct 2, 2012

This looks like the same issue as #3438.

@brson
Copy link
Contributor Author

brson commented Oct 2, 2012

Yep.

@brson brson closed this as completed Oct 2, 2012
bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
@rchaser53 @topecongiro
avoid not to truncate necessary chars (rust-lang#3640)
5b0ce0e
RalfJung pushed a commit to RalfJung/rust that referenced this issue Jun 9, 2024
@bors
Auto merge of rust-lang#3640 - folkertdev:add-pclmulqdq, r=RalfJung
4d5fd11 
add support for `pclmulqdq` intrinsic

This instruction is required in fast implementations of the crc32 checksum algorithm, and used in the https://crates.io/crates/crc32fast and https://crates.io/crates/zlib-rs crates.

Some questions from my side

- is my method for decomposing a `__m128i` into two separate `i64` values allright?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brson @Dretch