Skip to content

Use correct constructor naming conventions in core/std #3202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Aug 15, 2012 · 1 comment
Closed

Use correct constructor naming conventions in core/std #3202

brson opened this issue Aug 15, 2012 · 1 comment
Assignees
@brson
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Milestone
0.4

Comments

@brson
Copy link
Contributor

brson commented Aug 15, 2012

After changing the names of types to camel case, constructors will be in a weird place where they all have the same name as their types, but lowercase. There doesn't seem to be a consensus on what convention constructors should use yet.
@ghost ghost assigned catamorphism and brson Aug 31, 2012
@brson
Copy link
Contributor Author

brson commented Sep 10, 2012

Currently we are using the camel case convention for constructors. Eventually we will move to static new methods. Considering this done.

@brson brson closed this as completed Sep 10, 2012
RalfJung pushed a commit to RalfJung/rust that referenced this issue Dec 3, 2023
@bors
Auto merge of rust-lang#3202 - rust-lang:rustup-2023-12-03, r=saethlin
6318e9d 
Automatic Rustup
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@dependabot
Bump tests/perf/s2n-quic from f5d9d74 to d03cc47 (rust-lang#3202)
f6ab6bf 
Bumps [tests/perf/s2n-quic](https://github.com/aws/s2n-quic) from
`f5d9d74` to `d03cc47`.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/aws/s2n-quic/commit/d03cc470fa9812d06d204e312e4ada00079e96df"><code>d03cc47</code></a>
docs(s2n-quic): fips mode usage with rustls TLS provider (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2224">#2224</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/275dbfdf4a4072f4c620abf9849ca268d8bcdb46"><code>275dbfd</code></a>
chore(s2n-quic-transport): update dc manager dot snapshot (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2223">#2223</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/41ebf0c2ca92674412f9e70a35339b2da9f4f738"><code>41ebf0c</code></a>
test(s2n-quic-core): add microwave state example (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2222">#2222</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/391068e5f613b82bb465444eac88bbd278afc9e7"><code>391068e</code></a>
feat(s2n-quic-transport): dc Manager (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2218">#2218</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/c96e57c83c5cfe53e5da9beb26a610054c8a9333"><code>c96e57c</code></a>
feat(s2n-quic-core): generate state reactions to events (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2221">#2221</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/f23d87bbaad3ff58b65f1d23fff2e1b71754b870"><code>f23d87b</code></a>
feat(s2n-quic-core): allow for branching states on common events (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2219">#2219</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/5cac7eaae62fa08e88e00a5bc456e846334e98c8"><code>5cac7ea</code></a>
build(deps): bump JamesIves/github-pages-deploy-action (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2215">#2215</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/0f17963d8e6fbf7f6a5ab76f0ceefc1061cfa1f9"><code>0f17963</code></a>
--- (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2216">#2216</a>)</li>
<li>See full diff in <a
href="https://github.com/aws/s2n-quic/compare/f5d9d747805de846181536ecc2c0a6754a98e9ea...d03cc470fa9812d06d204e312e4ada00079e96df">compare
view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brson brson

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@brson @catamorphism