Skip to content

INVALID_THREAD is not a portable constant #2683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
graydon opened this issue Jun 21, 2012 · 3 comments
Closed

INVALID_THREAD is not a portable constant #2683

graydon opened this issue Jun 21, 2012 · 3 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@graydon
Copy link
Contributor

graydon commented Jun 21, 2012

in lock_and_signal.cpp, there's a made-up looking constant for the invalid pthread. This is not actually the right thing to do. There is no by-spec invalid pthread value. you have to use a separate flag and uninitialized memory or something.
@catamorphism
Copy link
Contributor

(bug triage) Still a bug; milestone seems correct.

@catamorphism
Copy link
Contributor

(bug triage) Same as what I said 2 months ago.

@alexcrichton
Copy link
Member

This is not used any more, closing for removed code.

RalfJung pushed a commit to RalfJung/rust that referenced this issue Nov 20, 2022
@bors
Auto merge of rust-lang#2683 - RalfJung:align_offset, r=RalfJung
8459a16 
make align_offset always work on no-provenance pointers

Fixes rust-lang/miri#2682
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#2683 - RalfJung:align_offset, r=RalfJung
94ddca1 
make align_offset always work on no-provenance pointers

Fixes rust-lang/miri#2682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@graydon @alexcrichton @catamorphism