Skip to content

Cross-crate overloading doesn't work #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catamorphism opened this issue Jun 15, 2012 · 7 comments
Closed

Cross-crate overloading doesn't work #2615

catamorphism opened this issue Jun 15, 2012 · 7 comments
Labels
A-linkage Area: linking into static, shared libraries and binaries A-type-system Area: Type system
Milestone
old 1.0 milestone

Comments

@catamorphism
Copy link
Contributor

as per a FIXME in core::num
@eholk
Copy link
Contributor

eholk commented Jun 15, 2012

Do we know this is the case? I'm pretty sure we are using this now.

@catamorphism
Copy link
Contributor Author

I assumed this was true because core::num is pretty new, but I'm not sure. Is there a test case?

@eholk
Copy link
Contributor

eholk commented Jun 15, 2012

I've got a bunch of code that implements + for [T] as an iface. I haven't noticed any cross-crate problems with it. I think we had some problems along these lines when I started this summer though.

@catamorphism
Copy link
Contributor Author

Ok, well, I still want there to be at least one test case (possibly an existing one) before I close this!

@pcwalton
Copy link
Contributor

I wrote that because @nikomatsakis had said he had found a bunch of issues with it, mainly in reachability checking IIRC (although I also remember he had trouble reproducing them). Paging him.

@nikomatsakis
Copy link
Contributor

These problems may have been fixed in the meantime. They were quite easy to reproduce: remove the get_elt() method from dvec and start using [].

pcwalton added a commit that referenced this issue Aug 7, 2012
@pcwalton
test: Add a dvec indexing operator test, which serves as a test for #…
6a7c714 
…2615 (cross-crate operator overloading).
@pcwalton
Copy link
Contributor

pcwalton commented Aug 7, 2012

Added a (working) test in 6a7c714; closing.

@pcwalton pcwalton closed this as completed Aug 7, 2012
RalfJung pushed a commit to RalfJung/rust that referenced this issue Oct 24, 2022
@bors
Auto merge of rust-lang#2615 - RalfJung:josh, r=oli-obk
71e81ab 
point to my fork of josh for now

This is the version of josh that I used to create rust-lang#103392.
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#2615 - RalfJung:josh, r=oli-obk
ff0f5b3 
point to my fork of josh for now

This is the version of josh that I used to create rust-lang#103392.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-linkage Area: linking into static, shared libraries and binaries A-type-system Area: Type system
Projects
None yet
Milestone
old 1.0 milestone
Development

No branches or pull requests
4 participants
@eholk @nikomatsakis @pcwalton @catamorphism