Skip to content

shape interpreter walks over fixed length vectors incorrectly #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
msullivan opened this issue Jun 15, 2012 · 1 comment
Closed

shape interpreter walks over fixed length vectors incorrectly #2613

msullivan opened this issue Jun 15, 2012 · 1 comment
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows

Comments

@msullivan
Copy link
Contributor 

fn main() {
    let arr = [1,2,3]/3;
    log(error, {a: arr, b: 42});
}

results in the output

rust: ([1, 2, 3]/3, 1)

which is clearly wrong.
@ghost ghost assigned msullivan Jun 15, 2012
@pcwalton
Copy link
Contributor

Probably an alignment bug.

@msullivan msullivan removed their assignment Jun 16, 2014
RalfJung pushed a commit to RalfJung/rust that referenced this issue Oct 24, 2022
@bors
Auto merge of rust-lang#2613 - RalfJung:scalar-only-field-retagging, …
b3d53ec 
…r=RalfJung

add scalar-abi-only field retagging option

`@saethlin` has requested a Stacked Borrows field retagging mode that matches when we do in terms of emitting `noalias` for LLVM. So here you go! Types with `Scalar` and `ScalarPair` ABI are being recursively retagged, everything else is not.

Given that many types can get `ScalarPair` ABI, I don't think this actually helps to make many things sound that are unsound under full field retagging -- but it might still be useful for some experimentation.
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#2613 - RalfJung:scalar-only-field-retagging, …
b51470a 
…r=RalfJung

add scalar-abi-only field retagging option

`@saethlin` has requested a Stacked Borrows field retagging mode that matches when we do in terms of emitting `noalias` for LLVM. So here you go! Types with `Scalar` and `ScalarPair` ABI are being recursively retagged, everything else is not.

Given that many types can get `ScalarPair` ABI, I don't think this actually helps to make many things sound that are unsound under full field retagging -- but it might still be useful for some experimentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pcwalton @msullivan