Skip to content

Fix or remove FIXME in std::smallintmap #2347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
catamorphism opened this issue May 3, 2012 · 2 comments
Closed

Fix or remove FIXME in std::smallintmap #2347

catamorphism opened this issue May 3, 2012 · 2 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@catamorphism
Copy link
Contributor

A FIXME in std::smallintmap says: "FIXME: Should not be @; there's a bug somewhere in rustc that requires this to be" (as in: the definition of the smallintmap type is @{mut v: [mut option<T>]} and should be {mut v: [mut option<T>]}). I tried fixing this (and changing insert to take its first argument by pointer), but maybe there's still a bug in rustc, as the fix causes map lookups to fail. So it seems more complicated.

@msullivan
Copy link
Contributor

Presumably it is getting passed by value somewhere or another and so it gets copied? What /should/ the behavior of copying a smallintmap be?

@catamorphism
Copy link
Contributor Author

Obsolete.

celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
tshepang added a commit to tshepang/rust that referenced this issue Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests

2 participants