Skip to content

Tracking issue for std::ascii reform (RFC 486) #19908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aturon opened this issue Dec 16, 2014 · 2 comments · Fixed by #19916
Closed

Tracking issue for std::ascii reform (RFC 486) #19908

aturon opened this issue Dec 16, 2014 · 2 comments · Fixed by #19916

Comments

@aturon
Copy link
Member

aturon commented Dec 16, 2014

Tracking issue for std::ascii reform (RFC 486)
@aturon aturon added the A-libs label Dec 16, 2014
@aturon
Copy link
Member Author

aturon commented Dec 16, 2014

cc @SimonSapin

@SimonSapin SimonSapin mentioned this issue Dec 16, 2014
Merged
@SimonSapin
Copy link
Contributor

I’ve published the removed functionality in an ascii crate on crates.io, after modernizing the API a bit. The source is at https://github.com/SimonSapin/rust-ascii

However, I am not planning on maintaining this crate further or keeping it up-to-date with language changes. I will happily give maintainership to whoever wants it.

bors added a commit that referenced this issue Dec 27, 2014
@bors
auto merge of #19916 : SimonSapin/rust/ascii-reform, r=sfackler
9b4fbc4 
Implements [RFC 486](rust-lang/rfcs#486). Fixes #19908.

* Rename `to_ascii_{lower,upper}` to `to_ascii_{lower,upper}case`, per #14401
* Remove the `Ascii` type and associated traits: `AsciiCast`, `OwnedAsciiCast`, `AsciiStr`, `IntoBytes`, and `IntoString`.
* As a replacement, add `.is_ascii()` to `AsciiExt`, and implement `AsciiExt` for `u8` and `char`.

[breaking-change]
bors added a commit that referenced this issue Dec 27, 2014
@bors
auto merge of #19916 : SimonSapin/rust/ascii-reform, r=sfackler
070ab63 
Implements [RFC 486](rust-lang/rfcs#486). Fixes #19908.

* Rename `to_ascii_{lower,upper}` to `to_ascii_{lower,upper}case`, per #14401
* Remove the `Ascii` type and associated traits: `AsciiCast`, `OwnedAsciiCast`, `AsciiStr`, `IntoBytes`, and `IntoString`.
* As a replacement, add `.is_ascii()` to `AsciiExt`, and implement `AsciiExt` for `u8` and `char`.

[breaking-change]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

std::ascii reform SimonSapin/rust
2 participants
@SimonSapin @aturon