Skip to content

non_uppercase_statics should be renamed for constants #17932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mahkoh opened this issue Oct 10, 2014 · 1 comment
Closed

non_uppercase_statics should be renamed for constants #17932

mahkoh opened this issue Oct 10, 2014 · 1 comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-lints Area: Lints (warnings about flaws in source code) such as unused_mut.

Comments

@mahkoh
Copy link
Contributor

mahkoh commented Oct 10, 2014 

src/clang/ll.rs:794:1: 794:55 warning: static constant `CXIdxEntityRef_Implicit` should have an uppercase name such as `CXIDXENTITYREF_IMPLICIT`, #[warn(non_uppercase_statics)] on by default
src/clang/ll.rs:794 pub const CXIdxEntityRef_Implicit: ::libc::c_uint = 2;
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@alexcrichton
Copy link
Member

cc @aturon, you may want to update rust-lang/rfcs#344 to rename this lint to something like non_uppercase_globals

@kmcallister kmcallister added A-diagnostics Area: Messages for errors, warnings, and lints A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. labels Oct 13, 2014
@aturon aturon mentioned this issue Oct 14, 2014
Closed
bors added a commit that referenced this issue Oct 15, 2014
@bors
auto merge of #18044 : aturon/rust/lint-conventions, r=pcwalton
ea8a5df 
[RFC 344](rust-lang/rfcs#344) proposes a set of naming conventions for lints. This PR
renames existing lints to follow the conventions.

Use the following sed script to bring your code up to date:

```
s/unnecessary_typecast/unused_typecasts/g
s/unsigned_negate/unsigned_negation/g
s/type_limits/unused_comparisons/g
s/type_overflow/overflowing_literals/g
s/ctypes/improper_ctypes/g
s/owned_heap_memory/box_pointers/g
s/unused_attribute/unused_attributes/g
s/path_statement/path_statements/g
s/unused_must_use/unused_must_use/g
s/unused_result/unused_results/g
s/non_uppercase_statics/non_upper_case_globals/g
s/unnecessary_parens/unused_parens/g
s/unnecessary_import_braces/unused_import_braces/g
s/unused_unsafe/unused_unsafe/g
s/unsafe_block/unsafe_blocks/g
s/unused_mut/unused_mut/g
s/unnecessary_allocation/unused_allocation/g
s/missing_doc/missing_docs/g
s/unused_imports/unused_imports/g
s/unused_extern_crate/unused_extern_crates/g
s/unnecessary_qualification/unused_qualifications/g
s/unrecognized_lint/unknown_lints/g
s/unused_variable/unused_variables/g
s/dead_assignment/unused_assignments/g
s/unknown_crate_type/unknown_crate_types/g
s/variant_size_difference/variant_size_differences/g
s/transmute_fat_ptr/fat_ptr_transmutes/g
```

Since a large number of lints are being renamed for RFC 344, this PR
adds some basic deprecation/renaming functionality to the pluggable lint
system. It allows a simple mapping of old to new names, and can warn
when old names are being used.

This change needs to be rolled out in stages. In this PR, the
deprecation warning is commented out, but the old name is forwarded to
the new one.

Once the PR lands and we have generated a new snapshot of the
compiler, we can add the deprecation warning and rename all uses of the
lints in the rust codebase. I will file a PR to do so.

Closes #16545
Closes #17932

r? @pcwalton
@aturon aturon closed this as completed in aabb6e7 Oct 15, 2014
lnicola pushed a commit to lnicola/rust that referenced this issue Aug 29, 2024
@bors
Auto merge of rust-lang#17932 - Veykril:default-reply-lat-sensitive, …
a9e3555 
…r=Veykril

fix: Fix panics for semantic highlighting at startup

Without this we might try to process semantic highlighting requests before the database has entries for the given file resulting in a panic. There is no work to be done either way so delay this like we do with other request handlers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-lints Area: Lints (warnings about flaws in source code) such as unused_mut.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustc: implement lint conventions (RFC 344) aturon/rust
3 participants
@alexcrichton @kmcallister @mahkoh