Skip to content

BitvSet::is_disjoint is reversed #16587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zwarich opened this issue Aug 18, 2014 · 1 comment
Closed

BitvSet::is_disjoint is reversed #16587

zwarich opened this issue Aug 18, 2014 · 1 comment

Comments

@zwarich
Copy link

zwarich commented Aug 18, 2014

The implementation of BitvSet::is_disjoint is this:

    #[inline]
    fn is_disjoint(&self, other: &BitvSet) -> bool {
        self.intersection(other).count() > 0
    }

It also shouldn't use count; it can just check whether the intersection iterator is empty directly.

@Gankra
Copy link
Contributor

Gankra commented Aug 18, 2014

On it

@bors bors closed this as completed in dcccf82 Aug 19, 2014
bors added a commit to rust-lang-ci/rust that referenced this issue Feb 18, 2024
ci: Update GitHub Actions and Node version

Use newer versions of actions; Node 16 -> 18

Fix several warnings in the actions tab regarding usage of the EOL Node 16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants