Skip to content

`make perf' failed with perf 3.2 #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lht opened this issue Jan 16, 2012 · 1 comment
Closed

`make perf' failed with perf 3.2 #1538

lht opened this issue Jan 16, 2012 · 1 comment

Comments

@lht
Copy link
Contributor

lht commented Jan 16, 2012

All perf tests failed with perf 3.2. Printout looks like:

test [run-pass] ../src/test/bench/99bob-iter.rs ... 
error: test run failed!
command: /usr/bin/perf stat -r 3 x86_64-unknown-linux-gnu/test/perf/99bob-iter.stage2-x86_64-unknown-linux-gnu
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
Failed opening logfd: Invalid argument

------------------------------------------

rust: upcall fail 'explicit failure', ../src/compiletest/runtest.rs:455
FAILED
test [run-pass] ../src/test/bench/99bob-pattern.rs ... 
error: test run failed!
command: /usr/bin/perf stat -r 3 x86_64-unknown-linux-gnu/test/perf/99bob-pattern.stage2-x86_64-unknown-linux-gnu
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
Failed opening logfd: Invalid argument
@ghost ghost assigned lht Jan 16, 2012
lht added a commit to lht/rust that referenced this issue Jan 16, 2012
@lht
build: Check and set perf --log-fd option
7df5478 
Linux perf tool version 3.2 introduced a new option "--log-fd" defaults
to 0, which leads to error "Failed opening logfd: Illegal argument" when
executing perf tests.

Set logfd to stderr to let perf test work.

Issue rust-lang#1538
lht added a commit that referenced this issue Jan 17, 2012
@lht
build: Check and set perf --log-fd option
7076d5d 
Linux perf tool version 3.2 introduced a new option "--log-fd" defaults
to 0, which leads to error "Failed opening logfd: Illegal argument" when
executing perf tests.

Set logfd to stderr to let perf test work.

Issue #1538
lht added a commit that referenced this issue Jan 17, 2012
@lht
build: Check and set perf --log-fd option
ef0775f 
Linux perf tool version 3.2 introduced a new option "--log-fd" defaults
to 0, which leads to error "Failed opening logfd: Illegal argument" when
executing perf tests.

Set logfd to stderr to let perf test work.

Issue #1538
@lht lht closed this as completed Jan 17, 2012
@lht
Copy link
Contributor Author

lht commented Jan 17, 2012

Fixed in ef0775f

@lht lht removed their assignment Jun 16, 2014
Kobzol pushed a commit to Kobzol/rust that referenced this issue Dec 30, 2024
@jyn514
Add a section for how to review code more easily (rust-lang#1538)
f15369c 
- How to hide whitespace
- Fetching PRs without having to add a new remote or copy-paste the URL of the author's fork
- How to review large blocks that have moved
- Suggest `git range-diff`. This section is still mostly incomplete; fixing an exact command that will work seems kinda tricky and I don't currently have time for it.
bors pushed a commit to rust-lang-ci/rust that referenced this issue Jan 2, 2025
@jyn514
Add a section for how to review code more easily (rust-lang#1538)
bc7f527 
- How to hide whitespace
- Fetching PRs without having to add a new remote or copy-paste the URL of the author's fork
- How to review large blocks that have moved
- Suggest `git range-diff`. This section is still mostly incomplete; fixing an exact command that will work seems kinda tricky and I don't currently have time for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lht