Skip to content

x install fails because bootstrap can't copy files from the llvm-project submodule #141393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iyernaveenr opened this issue May 22, 2025 · 7 comments · Fixed by #141568
Closed

x install fails because bootstrap can't copy files from the llvm-project submodule #141393

iyernaveenr opened this issue May 22, 2025 · 7 comments · Fixed by #141568
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@iyernaveenr
Copy link
Contributor

This goes back to:
#140913

Specifically:
#140913 (comment)

The fix did not work for me due to build issues. Could this be an incomplete fix?
@iyernaveenr iyernaveenr added the C-bug Category: This is a bug. label May 22, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 22, 2025
@jieyouxu
Copy link
Member

What specifically are

build issues?

@jieyouxu jieyouxu added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-needs-info Status: The issue lacks details necessary to triage or act on it. labels May 22, 2025
@iyernaveenr
Copy link
Contributor Author

What specifically are

build issues?

Quoting #140913 (comment) :
"
I get this error now with this fix:
/home/user/FOO_rustc_source/rust/build/x86_64-unknown-linux-gnu/ci-llvm/bin/llvm-strip does not exist; skipping copy
thread 'main' panicked at src/bootstrap/src/lib.rs:1874:13:
ERROR: File "/home/user/FOO_rustc_source/rust/src/llvm-project/llvm/LICENSE.TXT" not found!

I'm on top of the following commit:
commit bbd3a5a (HEAD -> master, origin/try-perf, origin/try, origin/perf-tmp, origin/master, origin/auto, origin/HEAD)

So, it includes this fix:
commit 6cab15c
Merge: 28174fc 475e743
Author: bors [email protected]
Date: Tue May 20 12:44:14 2025 +0000
"

@jieyouxu
Copy link
Member

jieyouxu commented May 22, 2025 •
edited
Loading

Can you please share your bootstrap.toml and/or ./configure/./x invocation? Are you using a custom/external LLVM?

@iyernaveenr
Copy link
Contributor Author

iyernaveenr commented May 22, 2025 •
edited
Loading

Can you please share your bootstrap.toml and/or ./configure/./x invocation?

There was no bootstrap.toml. There was only bootstrap.example.toml that came with the repo by default when you clone it. I used export DESTDIR=<custom user path> && ./x.py build && ./x.py install

Are you using a custom/external LLVM?

No

@iyernaveenr
Copy link
Contributor Author

iyernaveenr commented May 26, 2025 •
edited
Loading

@onur-ozkan Could you please comment? Thanks!

@onur-ozkan
Copy link
Member

Seems like LLVM submodule isn't initialized. I will check that shortly.

@onur-ozkan onur-ozkan changed the title llvm-* and llc binaries missing from rustc build - Incomplete fix? x install fails because bootstrap can't copy files from the llvm-project submodule May 26, 2025
@onur-ozkan onur-ozkan removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. S-needs-info Status: The issue lacks details necessary to triage or act on it. labels May 26, 2025
@onur-ozkan onur-ozkan mentioned this issue May 26, 2025
Merged
@onur-ozkan
Copy link
Member

Seems like LLVM submodule isn't initialized. I will check that shortly.

Yeah, that was the problem. #141568 should fix this.

jieyouxu added a commit to jieyouxu/rust that referenced this issue May 26, 2025
@jieyouxu
Rollup merge of rust-lang#141568 - onur-ozkan:141393-fix, r=Kobzol
1f817bc 
dist: make sure llvm-project submodule is present

Zero-config `x install` fails when bootstrap tries to copy files from the LLVM submodule because it's not properly initialized/handled. This diff handles that.

Fixes rust-lang#141393
@bors bors closed this as completed in 2c5361a May 27, 2025
rust-timer added a commit that referenced this issue May 27, 2025
@rust-timer
Unrolled build for #141568
fbc85fc 
Rollup merge of #141568 - onur-ozkan:141393-fix, r=Kobzol

dist: make sure llvm-project submodule is present

Zero-config `x install` fails when bootstrap tries to copy files from the LLVM submodule because it's not properly initialized/handled. This diff handles that.

Fixes #141393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dist: make sure llvm-project submodule is present onur-ozkan/rust
4 participants
@iyernaveenr @jieyouxu @onur-ozkan @rustbot