Skip to content

Tracking Issue for const_eq_ignore_ascii_case #131719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 of 3 tasks
okaneco opened this issue Oct 15, 2024 · 5 comments
Open
1 of 3 tasks

Tracking Issue for const_eq_ignore_ascii_case #131719

okaneco opened this issue Oct 15, 2024 · 5 comments
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@okaneco
Copy link
Contributor

okaneco commented Oct 15, 2024 •
edited
Loading

Feature gate: #![feature(const_eq_ignore_ascii_case)]

This is a tracking issue for const eq_ignore_ascii_case on [u8] and str.

Public API

impl [u8] {
    pub const fn eq_ignore_ascii_case(&self, other: &[u8]) -> bool;
}
impl str {
    pub const fn eq_ignore_ascii_case(&self, other: &str) -> bool;
}

Steps / History

Unresolved Questions

  • None yet.

Footnotes

  1. https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html ↩
@okaneco okaneco added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Oct 15, 2024
@okaneco okaneco mentioned this issue Oct 15, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 5, 2024
@matthiaskrgr
Rollup merge of rust-lang#131721 - okaneco:const_eq_ignore_ascii_case…
6c8ea8f 
…, r=m-ou-se

Add new unstable feature `const_eq_ignore_ascii_case`

Tracking issue - rust-lang#131719

Mark `[u8]`, `str` `eq_ignore_ascii_case` functions const

---

The codegen for this implementation matches the existing `iter::zip` implementation better than incrementing with a counter

while loop with counter - https://rust.godbolt.org/z/h9cs5zajc
while let - https://rust.godbolt.org/z/ecMeMjjEb
bors added a commit to rust-lang-ci/rust that referenced this issue Nov 6, 2024
@bors
Auto merge of rust-lang#131721 - okaneco:const_eq_ignore_ascii_case, …
2796048 
…r=m-ou-se

Add new unstable feature `const_eq_ignore_ascii_case`

Tracking issue - rust-lang#131719

Mark `[u8]`, `str` `eq_ignore_ascii_case` functions const

---

The codegen for this implementation matches the existing `iter::zip` implementation better than incrementing with a counter

while loop with counter - https://rust.godbolt.org/z/h9cs5zajc
while let - https://rust.godbolt.org/z/ecMeMjjEb
@paolobarbolini
Copy link
Contributor

@the8472 I'd like to stabilize this feature. The feature in itself seems very basic and can be 100% implemented using const-stable APIs. The feature has been const-unstable for almost 6 months.

@paolobarbolini
Copy link
Contributor

I'd like to stabilize this feature. The feature in itself seems very basic and can be 100% implemented using const-stable APIs. The feature has been const-unstable for almost 6 months.

Maybe you can help with this @m-ou-se

@m-ou-se
Copy link
Member

m-ou-se commented May 1, 2025

@rfcbot merge

@rfcbot
Copy link
Collaborator

rfcbot commented May 1, 2025 •
edited by dtolnay
Loading

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels May 1, 2025
@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label May 25, 2025
@rfcbot
Copy link
Collaborator

rfcbot commented May 25, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@m-ou-se @paolobarbolini @rfcbot @okaneco