Skip to content

rust-gdb crashes on FreeBSD due to invalid sed syntax #110334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
asomers opened this issue Apr 14, 2023 · 0 comments · Fixed by #110335
Closed

rust-gdb crashes on FreeBSD due to invalid sed syntax #110334

asomers opened this issue Apr 14, 2023 · 0 comments · Fixed by #110335
Labels
C-bug Category: This is a bug. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly.

Comments

@asomers
Copy link
Contributor

asomers commented Apr 14, 2023

Code

I tried this code:

rust-gdb

I expected to see this happen: GDB starts

Instead, this happened: GDB crashed:

$ rust-gdb
sed: 1: "s/commit-hash: \(\w*\)/ ...": RE error: trailing backslash (\)

Version it worked on

It most recently worked on:
rustc 1.70.0-nightly (4a04d08 2023-03-18)

Version with regression

rustc 1.70.0-nightly (a41fc00ea 2023-04-13)
binary: rustc
commit-hash: a41fc00eaf352541008965fec0dee811e44373b3
commit-date: 2023-04-13
host: x86_64-unknown-freebsd
release: 1.70.0-nightly
LLVM version: 16.0.2

The bug was introduced by commit 8dd0ec6 , which invokes sed with GNU-specific syntax.

@rustbot modify labels: +regression-from-stable-to-nightly -regression-untriaged
@asomers asomers added C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. labels Apr 14, 2023
@rustbot rustbot added regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. I-prioritize Issue: Indicates that prioritization has been requested for this issue. and removed regression-untriaged Untriaged performance or correctness regression. labels Apr 14, 2023
@asomers asomers mentioned this issue Apr 14, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Apr 15, 2023
@bors
Auto merge of rust-lang#110335 - asomers:rust-gdb-freebsd, r=jyn514
825c706 
Fix rust-gdb on FreeBSD

"\w" is a GNU-specific extension to sed.  Avoid it.

Fixes rust-lang#110334
Signed-off-by: Alan Somers <[email protected]>
@bors bors closed this as completed in 2f45d19 Apr 15, 2023
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix rust-gdb on FreeBSD asomers/rust
3 participants
@asomers @apiraino @rustbot