Skip to content

Columns in spans are one-too-small by convention #10848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huonw opened this issue Dec 7, 2013 · 0 comments
Closed

Columns in spans are one-too-small by convention #10848

huonw opened this issue Dec 7, 2013 · 0 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints

Comments

@huonw
Copy link
Member

huonw commented Dec 7, 2013

E.g. a file that consists of a single & generates the following errors in rustc & gcc respectively (other compilers match gcc):

column.rs:1:0: 1:1 error: expected item but found `&`
column.rs:1 &
            ^
column.c:1:1: error: expected identifier or ‘(’ before ‘&’ token
 &
 ^

The column mismatch for the start of the expression (i.e. the 0 in 1:0:) means that Emacs' M-x compile jump-to-error mode lands one column before the expression in question.

@bors bors closed this as completed in 3d43543 Jan 2, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 2, 2023
… r=llogiq

[`wildcard_imports`] Modules that contain `prelude` are also allowed

This commit fixes rust-lang#10846 by checking if the path segment contains the word "prelude", allowing us
`use module_prelude::*`.

changelog: [`wildcard_imports`]: Modules that contain `prelude` are also allowed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints
Projects
None yet
Development

No branches or pull requests

1 participant