Skip to content

Commit f1548ec

Browse files
committed
Remove redundant -Wl,-syslibroot
Clang already passes this when invoking the linker: https://github.com/llvm/llvm-project/blob/llvmorg-17.0.6/clang/lib/Driver/ToolChains/Darwin.cpp#L439-L442
1 parent d7bd9cd commit f1548ec

File tree

1 file changed

+7
-1
lines changed
  • compiler/rustc_codegen_ssa/src/back

1 file changed

+7
-1
lines changed

Diff for: compiler/rustc_codegen_ssa/src/back/link.rs

+7-1
Original file line numberDiff line numberDiff line change
@@ -2939,7 +2939,13 @@ fn add_apple_sdk(cmd: &mut dyn Linker, sess: &Session, flavor: LinkerFlavor) {
29392939

29402940
match flavor {
29412941
LinkerFlavor::Darwin(Cc::Yes, _) => {
2942-
cmd.args(&["-isysroot", &sdk_root, "-Wl,-syslibroot", &sdk_root]);
2942+
// Use `-isysroot` instead of `--sysroot`, as only the former
2943+
// makes Clang treat it as a platform SDK.
2944+
//
2945+
// This is admittedly a bit strange, as on most targets
2946+
// `-isysroot` only applies to include header files, but on Apple
2947+
// targets this also applies to libraries and frameworks.
2948+
cmd.args(&["-isysroot", &sdk_root]);
29432949
}
29442950
LinkerFlavor::Darwin(Cc::No, _) => {
29452951
cmd.args(&["-syslibroot", &sdk_root]);

0 commit comments

Comments
 (0)