Redesign the playground's header #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will power our new popover menu buttons
This will allow children of the button to close the popper, such as when performing a "one-shot" action or to provide an inline "close" button.
This simplifies styling as the children don't have to deal with being constrained by the header styles.
This streamlines the interaction of "no, please go away popup".
We think this is because it's taking the (missing) scrollbar into account during initial positioning. When it realizes it's not there, it adjusts, causing a bit of motion.
This was referenced Apr 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This design from @lqd reduces the visual clutter of the playground's header, allowing new users to quickly identify important aspects and improving fit on smaller screen sizes.
before:
after:
We also now have the ability to provide a bit of descriptive text about each option:
Some pre-release feedback was gathered from users.