Skip to content

Fix whitelisting documentation links in book. #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2017

Conversation

treiff
Copy link
Contributor

@treiff treiff commented Sep 15, 2017

While working on #990 depreciated the whitelisted_function I noticed a couple of links in the book that also should be updated to refer to the updated methods.

@fitzgen one question here, I assume I will also need to update the version number within the url as new documentation won't be built until the next release?

@fitzgen
Copy link
Member

fitzgen commented Sep 15, 2017

@fitzgen one question here, I assume I will also need to update the version number within the url as new documentation won't be built until the next release?

Ooo I didn't think of that. Too bad there is no way to link to the latest version on docs.rs, AFAIK.

Let's leave this open until we publish the next version.

Update to reference `whitelist_type` function.
@treiff treiff force-pushed the fix-link-references-in-book branch from 888c7e8 to 31700bf Compare September 15, 2017 12:11
@fitzgen
Copy link
Member

fitzgen commented Sep 19, 2017

@treiff, BTW, I'm not sure if you're aware that the "impl period" has just begun, but the folks hacking on bindgen during the impl period are hanging out in https://gitter.im/rust-impl-period/WG-dev-tools-bindgen if you want to join us :)

@fitzgen
Copy link
Member

fitzgen commented Oct 27, 2017

@bors-servo r+

Finally!

@bors-servo
Copy link

📌 Commit 31700bf has been approved by fitzgen

@bors-servo
Copy link

⌛ Testing commit 31700bf with merge a57d880...

bors-servo pushed a commit that referenced this pull request Oct 27, 2017
Fix whitelisting documentation links in book.

While working on #990 depreciated the `whitelisted_function` I noticed a couple of links in the book that also should be updated to refer to the updated methods.

@fitzgen one question here, I assume I will also need to update the version number within the url as new documentation won't be built until the next release?
@fitzgen
Copy link
Member

fitzgen commented Oct 27, 2017

Thanks again @treiff !

@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: fitzgen
Pushing a57d880 to master...

@bors-servo bors-servo merged commit 31700bf into rust-lang:master Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants