Generate constants for enums by default #976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cldfire
changed the title
|
Whoops, I completely overlooked My apologies, let me go look into that. EDIT: There we go, all green. |
Cldfire
changed the title
|
Looks great! Squash these commits into one and we can merge this PR! Thanks @Cldfire :) |
Also simplifies the logic that determines which enum variation gets chosen.
|
Squashed :) |
|
@bors-servo r+ Thanks again @Cldfire! |
|
📌 Commit 89915f9 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Sep 11, 2017
Generate constants for enums by default Closes #758. The first commit does strictly what the issue description described, the second does a small amount of (what I believe is) logic simplification. Hopefully I didn't miss any tests when adding the `--rustified-enum .*` flag to the ones that needed it; all of the tests are passing for me, though, so I don't think I did.
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #758.
The first commit does strictly what the issue description described, the second does a small amount of (what I believe is) logic simplification.
Hopefully I didn't miss any tests when adding the
--rustified-enum .*flag to the ones that needed it; all of the tests are passing for me, though, so I don't think I did.