-
Notifications
You must be signed in to change notification settings - Fork 743
No more syntex #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
No more syntex #940
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
66743be
Add the TypeKind name to the IR graphviz output
fitzgen 7346811
Run `rustfmt` on the test actual output and expectations
fitzgen 61743aa
Use `quote` instead of `syntex` for Rust code generation
fitzgen 4f0aa3e
Print time phases for the stylo sanity test
fitzgen 6e4383a
Fix units and formatting of time phases
fitzgen a93d0fb
We can afford the exra cycles to use double precision floats here
fitzgen 17f13b3
Add a timer for rustfmt'ing the generated bindings
fitzgen efdb1c5
Explicitly install the latest rustfmt in CI
fitzgen cca4037
Also print rustfmt's stderr for expectations
fitzgen 231bccb
Note that we need `rustfmt` to run tests now
fitzgen 04f020b
Use the `quote!` macro for `link_name` attributes
fitzgen 46f74c1
Just check for `rustfmt`; don't install it
fitzgen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when
rustfmt
changes the default formatting? All our CI breaks until we update them? That seems not great :(There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, because both the generated bindings and the expectations are run through
rustfmt
before being compared.