Avoid generating fields/methods for opaque objects #936
Conversation
Hm... It doesn't fail for me with libclang 4, nor on CI. Can you share what your local failures look like? |
src/codegen/mod.rs
Outdated
| debug_assert!(fields.is_empty()); | ||
| debug_assert!(methods.is_empty()); | ||
| // fields.clear(); | ||
| // methods.clear(); |
There was a problem hiding this comment.
Nitpick: these commented out lines should be removed.
src/codegen/mod.rs
Outdated
| if is_opaque { | ||
| fields.clear(); | ||
| methods.clear(); | ||
| // Opaque item should not have generated methods, fields |
There was a problem hiding this comment.
Nitpick: missing a period at the end of this sentence.
|
@bors-servo r+ Thanks again @jhod0 ! |
|
📌 Commit 034200a has been approved by |
Avoid generating fields/methods for opaque objects WIP fix for issue #929 With libclang 4, passes all tests on my machine except `dump_preprocessed_input`, but that fails on the master branch as well
|
As for the failing test, I had forgotten to add clang to my PATH. I added it and the test passes |
Ah, great to hear that :) |
|
☀️ Test successful - status-travis |
WIP fix for issue #929
With libclang 4, passes all tests on my machine except
dump_preprocessed_input, but that fails on the master branch as well