Fix recursive whitelisting and handling of opaque for derive default #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix regression of derive default analysis. Also fix opaque handing exposed by the above fix.
photoszzt
changed the title
fitzgen
approved these changes
Aug 3, 2017
| @@ -158,7 +158,7 @@ impl<'ctx, 'gen> MonotoneFramework for CannotDeriveDefault<'ctx, 'gen> { | |||
| } | |||
| }; | |||
|
|
|||
| if ty.is_opaque(self.ctx, item) { | |||
| if item.is_opaque(self.ctx, &()) { | |||
There was a problem hiding this comment.
Ah, is the idea that we missed the opaque_by_name case before?
|
@bors-servo r+ |
|
📌 Commit 8c6a253 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 3, 2017
Fix recursive whitelisting and handling of opaque for derive default Fix regression of derive default analysis. Also fix opaque handing exposed by the above fix. r? @fitzgen
|
💔 Test failed - status-travis |
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Aug 3, 2017
Fix recursive whitelisting and handling of opaque for derive default Fix regression of derive default analysis. Also fix opaque handing exposed by the above fix. r? @fitzgen
|
☀️ Test successful - status-travis |
bors-servo
pushed a commit
that referenced
this pull request
Aug 4, 2017
Fix recursive whitelisting and handling of opaque for derive default Fix regression of derive default analysis. Also fix opaque handing exposed by the above fix. r? @fitzgen
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression of derive default analysis.
Also fix opaque handing exposed by the above fix. r? @fitzgen