Skip to content

Add a template for release announcements #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2017
Merged

Add a template for release announcements #865

merged 1 commit into from
Jul 31, 2017

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Jul 28, 2017

And a script to find all the folks who contributed to the release.

Anything we should add or remove to the release announcement template? Once we've hashed this out, I'll make the first release announcement thread on u.r-l.o :-)

r? @emilio @nrc

emilio
emilio approved these changes Jul 28, 2017
View reviewed changes
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, r=me. Though not sending it to bors yet just in case you want more feedback.

releases/release-announcement-template.md Outdated
`bindgen` automatically generates Rust FFI bindings to C and C++ libraries.

* [GitHub][]
* [crates.io][]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, I'd expect you to need [crates.io][crates.io], nice!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a docs link too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emilio: when the slug matches the link's text, you can abbreviate to [blah][]. Pretty handy!

@nrc: great idea!

nrc
nrc approved these changes Jul 29, 2017
View reviewed changes
Copy link
Member

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some very minor comments inline (which I won't be offended if you ignore :-) )

releases/release-announcement-template.md

```toml
bindgen = "$TODO_VERSION"
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put this above the links to GH/crates.io since it is probably more useful for many users.

releases/release-announcement-template.md Outdated
`bindgen` automatically generates Rust FFI bindings to C and C++ libraries.

* [GitHub][]
* [crates.io][]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a docs link too?

releases/release-announcement-template.md Outdated
* [Issues labeled "easy"][easy]
* [Issues labeled "less easy"][less-easy]
* Still can't find something to work on? [Drop a comment here][looking]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add some boilerplate text about non-code contributions (reporting bugs, docs, etc.) and maybe a direct link to file a new issue

tmfink
tmfink reviewed Jul 30, 2017
View reviewed changes
Copy link
Contributor

@tmfink tmfink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion

releases/friends.sh Outdated
set -eu
set -o pipefail

cd $(dirname $0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest quoting like "$(dirname "$0")"

@fitzgen
Copy link
Member Author

fitzgen commented Jul 31, 2017

Thanks for the feedback everyone! Very appreciated :)

@fitzgen
Add a template for release announcements
c8e237f 
And a script to find all the folks who contributed to the release.
@fitzgen fitzgen force-pushed the release-announcements-template branch from 16cb32b to c8e237f Compare July 31, 2017 16:55
@fitzgen
Copy link
Member Author

fitzgen commented Jul 31, 2017

@bors-servo r=emilio,nrc,tmfink

@bors-servo
Copy link

📌 Commit c8e237f has been approved by emilio,nrc,tmfink

@tmfink
Copy link
Contributor

tmfink commented Jul 31, 2017

Small suggestion (the sequel)

@bors-servo
Copy link

⌛ Testing commit c8e237f with merge 4f92dd4...

bors-servo pushed a commit that referenced this pull request Jul 31, 2017
Auto merge of #865 - fitzgen:release-announcements-template, r=emilio…
4f92dd4 
…,nrc,tmfink

Add a template for release announcements

And a script to find all the folks who contributed to the release.

Anything we should add or remove to the release announcement template? Once we've hashed this out, I'll make the first release announcement thread on u.r-l.o :-)

r? @emilio @nrc
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: emilio,nrc,tmfink
Pushing 4f92dd4 to master...

@bors-servo bors-servo merged commit c8e237f into rust-lang:master Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmfink tmfink tmfink left review comments

@nrc nrc nrc approved these changes

@emilio emilio emilio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fitzgen @bors-servo @tmfink @nrc @emilio