Skip to content

Remove the incomplete --dummy-uses feature #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2017

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Jul 27, 2017

This would generate dummy uses of all the whitelisted types, which we were planning on eventually using to generate DWARF for more layout testing of our types, but we decided that isn't worth the trouble. Kill it!

r? @emilio

Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in for negative diffs.

@emilio
Copy link
Contributor

emilio commented Jul 27, 2017

@bors-servo r+

@bors-servo
Copy link

📌 Commit f36b86f has been approved by emilio

@emilio emilio mentioned this pull request Jul 27, 2017
@bors-servo
Copy link

⌛ Testing commit f36b86f with merge 312fbd1...

bors-servo pushed a commit that referenced this pull request Jul 27, 2017
Remove the incomplete `--dummy-uses` feature

This would generate dummy uses of all the whitelisted types, which we were planning on eventually using to generate DWARF for more layout testing of our types, but we decided that isn't worth the trouble. Kill it!

r? @emilio
@bors-servo
Copy link

💔 Test failed - status-travis

@fitzgen
Copy link
Member Author

fitzgen commented Jul 28, 2017

Forgot to remove the doc_mod!, will update in a minute

This would generate dummy uses of all the whitelisted types, which we were
planning on eventually using to generate DWARF for more layout testing of our
types, but we decided that isn't worth the trouble. Kill it!
@fitzgen
Copy link
Member Author

fitzgen commented Jul 28, 2017

@bors-servo r=emilio

@bors-servo
Copy link

📌 Commit bdb29b2 has been approved by emilio

@bors-servo
Copy link

⌛ Testing commit bdb29b2 with merge 3a9a675...

bors-servo pushed a commit that referenced this pull request Jul 28, 2017
Remove the incomplete `--dummy-uses` feature

This would generate dummy uses of all the whitelisted types, which we were planning on eventually using to generate DWARF for more layout testing of our types, but we decided that isn't worth the trouble. Kill it!

r? @emilio
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: emilio
Pushing 3a9a675 to master...

@bors-servo bors-servo merged commit bdb29b2 into rust-lang:master Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants