Skip to content

(WIP) Setup Appveyor #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2017
Merged

(WIP) Setup Appveyor #846

merged 1 commit into from
Jul 26, 2017

Conversation

UK992
Copy link
Contributor

@UK992 UK992 commented Jul 23, 2017

CC @upsuper @emilio

Issues:

  • test/expectations fails at:
error[E0512]: transmute called with differently sized types: u64 (64 bits) to i32 (32 bits)
  --> tests\bitfield_align_2.rs:78:18
   |
78 |         unsafe { ::std::mem::transmute(val as u64) }
   |                  ^^^^^^^^^^^^^^^^^^^^^ transmuting between 64 bits and 32 bits
  • MSVC with LLVM 3.9: many tests fails
  • 32-bit builds: many tests fails

Appveyor build: https://ci.appveyor.com/project/UK992/rust-bindgen/build/1.0.62

@upsuper
Copy link
Contributor

upsuper commented Jul 23, 2017

Hmmm... I wasn't aware of tests inside tests/expectations... and yeah, it fails for the same reason locally, will investigate.

32bit builds seem to be much broken at present...

Should we probably merge this and fix the failures latter?

@fitzgen
Copy link
Member

fitzgen commented Jul 24, 2017

A lot of the test scripts seems like copy/paste of functionality we have in existing scripts. Is the reason they can't be shared because the existing scripts are bash? If so, we should file a follow up to port them all to python or something. I'd really like to avoid duplicating them, as it will make changing them much more difficult.

Should we probably merge this and fix the failures latter?

Ideally mark them as "allow failures" somehow, and then when we fix them, remove that annotation. Does appveyor allow this kind of thing?

@fitzgen
Copy link
Member

fitzgen commented Jul 26, 2017

@UK992 would you mind rebasing and squashing this PR? Then we can land it and address the above concerns as follow ups.

@fitzgen
Copy link
Member

fitzgen commented Jul 26, 2017

/me grumbles that appveyor's results are impossible to read if one is red-green colorblind

@UK992
Copy link
Contributor Author

UK992 commented Jul 26, 2017

done.

@fitzgen
Copy link
Member

fitzgen commented Jul 26, 2017

Thanks @UK992! Very appreciated :)

@fitzgen fitzgen merged commit d73507e into rust-lang:master Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants