-
Notifications
You must be signed in to change notification settings - Fork 743
item: Consider replaced items hidden. #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b4740c
to
c30320f
Compare
By modifying this test header, I get a similar error (using this PR and #85). Not sure if we want to put this off for another PR or not. diff --git a/tests/headers/replaces_double.hpp b/tests/headers/replaces_double.hpp
index 1a78b0d..74d500b 100644
--- a/tests/headers/replaces_double.hpp
+++ b/tests/headers/replaces_double.hpp
@@ -7,14 +7,15 @@ struct Wrapper {
};
using Type = Wrapped;
};
template<typename T>
class Rooted {
using MaybeWrapped = typename Wrapper<T>::Type;
MaybeWrapped ptr;
-
- /**
- * <div rustbindgen replaces="Rooted_MaybeWrapped"></div>
- */
- using MaybeWrapped_simple = T;
};
+
+/**
+ * <div rustbindgen replaces="Rooted_MaybeWrapped"></div>
+ */
+template <typename T>
+using MaybeWrapped_simple = T; Results in this error due to duplicate types:
|
Nevermind: I think I failed to recompile. |
Merged
@bors-servo r+ |
📌 Commit c30320f has been approved by |
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81
r? @nox