Turn the two noisiest error!s into warn!s #80
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
requested changes
Oct 12, 2016
| @@ -468,7 +468,7 @@ impl Type { | |||
| return Err(ParseError::Recurse); | |||
| } | |||
|
|
|||
| error!("invalid type {:?}", ty); | |||
| warn!("invalid type {:?}", ty); | |||
There was a problem hiding this comment.
This can be an error, but it is not if ty.spelling().is_empty(), so I think we want to wrap that in an if.
| @@ -444,7 +444,7 @@ impl ClangItemParser for Item { | |||
| if cursor.kind() == clangll::CXCursor_UnexposedDecl { | |||
| Err(ParseError::Recurse) | |||
| } else { | |||
| error!("Unhandled cursor kind: {}", ::clang::kind_to_str(cursor.kind())); | |||
| warn!("Unhandled cursor kind: {}", ::clang::kind_to_str(cursor.kind())); | |||
There was a problem hiding this comment.
We should keep this, and if we don't care about some specific cursor, like MacroExpansion, we should do something like:
match cursor.kind() {
kind @ CXCursor_MacroExpansion | /* others? */ => debug!("Ignoring cursor kind {}", ::clang::kind_to_str(kind)),
other => error!("Unhandled cursor kind: {}", ::clang::kind_to_str(kind)),
}
|
☔ The latest upstream changes (presumably #85) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I don't think we want this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @emilio