codegen: Make comments indentation-aware. #799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
r? @fitzgen |
fitzgen
approved these changes
Jul 10, 2017
src/ir/item.rs
Outdated
| ctx.options().conservative_inline_namespaces | ||
| }) | ||
| }) | ||
| .fold(1, |i, _| i + 1) |
There was a problem hiding this comment.
Isn't this fold just <iterator>.count() + 1? Better not to make readers verify that the fold is just counting, when there's a std method for counting.
There was a problem hiding this comment.
I just moved code around, but sure :)
| "/// hello\n/// world\n/// foo"); | ||
|
|
||
| assert_eq!(preprocess("/**\nhello\n*world\n*foo\n*/".to_owned()), | ||
| assert_eq!(preprocess("/**\nhello\n*world\n*foo\n*/", 0), |
There was a problem hiding this comment.
Would be nice to have a unit test with nonzero indent for comment preprocessing.
There was a problem hiding this comment.
I'm not a super-fan of unit tests, but will do
There was a problem hiding this comment.
(err, for stuff that can be integration-tested, I mean)
This commit moves comment processing to a central place (well, two, because of field docs, but that's fine). Also, it makes comments indentation aware, so multiline comments don't appear garbled. Finally, it also fixes an out-of-bounds panic when processing an empty multiline comment.
|
@bors-servo r=fitzgen |
|
📌 Commit 96304f9 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jul 10, 2017
codegen: Make comments indentation-aware. This commit moves comment processing to a central place (well, two, because of field docs, but that's fine). Also, it makes comments indentation aware, so multiline comments don't appear garbled. Finally, it also fixes an out-of-bounds panic when processing an empty multiline comment.
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves comment processing to a central place (well, two, because of
field docs, but that's fine).
Also, it makes comments indentation aware, so multiline comments don't appear
garbled.
Finally, it also fixes an out-of-bounds panic when processing an empty multiline
comment.