Gate on libclang 4 CI passing :) #720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
force-pushed
the
testing-libclang-versions
branch
from
ba80e57 to
b032c63
Compare
Rather than having a tests that we only run if libclang >= 3.9, this makes the test suite dynamically detect when we have different expectations for different libclang versions. It does this by adding `tests/expectations/tests/libclang-$VERSION` directories, and `testing_only_libclang_$VERSION` features that are consulted when the usual expectation file does not exist. Fixes rust-lang#697
fitzgen
force-pushed
the
testing-libclang-versions
branch
from
b032c63 to
dc09012
Compare
fitzgen
changed the title
|
CI is green with libclang 4 🎉 🎉 🎉 r? @emilio |
|
I'm wary of how this will turn out in order to update tests, but it's probably fine, and the extra test coverage is more than worth it. @bors-servo r+ |
|
📌 Commit dc09012 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
May 25, 2017
Gate on libclang 4 CI passing :) Need those test expectation diffs across libclang versions from Travis CI...
I just went through the process (I don't have libclang 4 installed) and it wasn't so bad. |
|
nor libclang 3.8 installed for that matter |
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need those test expectation diffs across libclang versions from Travis CI...