Add bitfield allocation unit constructors #707
Conversation
This commit gives bindgen the ability to generate constructors for bitfield allocation units. This enables more ergonomic use of struct literals for bindings structs that contain bitfields. Additionally, when we are generating unstable Rust, these constructors are marked as const functions. This enables the creation of const binding structs that contain bitfields.
|
|
|
So I side stepped the unstable testing question by always generating bitfield constructors, but only making them |
| let bitfield_unit_val = | ||
| { | ||
| let bitfield_unit_val = | ||
| { |
src/codegen/mod.rs
Outdated
| ast::ItemKind::Impl(_, _, _, _, _, ref items) => { | ||
| assert_eq!(items.len(), 1); | ||
|
|
||
| match items.get(0).unwrap().node { |
There was a problem hiding this comment.
I'm pretty sure just doing items[0] will yield a better error message. Can't it be done that way?
There was a problem hiding this comment.
Also, I think this method may be more readable writing it as:
let items = match ctor_impl.unwrap().node {
ast::ItemKind::Impl(_, _, ..., items) => items,
_ => unreachable!(),
};
assert_eq!(items.len(), 1);
let (sig, body) = match items[0].node {
ast::ImplItemKind::Method(sig, body) => (sig, body),
_ => unreachable!(),
};
// ...
|
Also, thanks for testing the constructors with enums, that's quite nice :) |
This commit flattens the nesting in `Bitfield::extend_ctor_impl`, as requested in review, because it was getting pretty deep. Should be easier to read now.
|
@bors-servo r=emilio Thanks for the speedy review! Yeah, the generated code isn't exactly pretty, but I agree that it isn't a major concern. What is important is making it correct and easy to maintain. |
|
📌 Commit 15b72b7 has been approved by |
Add bitfield allocation unit constructors This commit gives bindgen the ability to generate constructors for bitfield allocation units. This enables more ergonomic use of struct literals for bindings structs that contain bitfields. Additionally, when we are generating unstable Rust, these constructors are marked as const functions. This enables the creation of const binding structs that contain bitfields. (Something necessary for Servo's usage of SpiderMonkey). r? @emilio
|
☀️ Test successful - status-travis |
This commit gives bindgen the ability to generate constructors for bitfield allocation units. This enables more ergonomic use of struct literals for bindings structs that contain bitfields.
Additionally, when we are generating unstable Rust, these constructors are marked as const functions. This enables the creation of const binding structs that contain bitfields. (Something necessary for Servo's usage of SpiderMonkey).
r? @emilio