Add other bitwise ops for bitflag enums #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
approved these changes
May 11, 2017
|
Looks great -- thanks @jonhoo! We might want to also implement all the bitwise operations, but this obviously is no reason not to land this patch now. Thanks again! @bors-servo r+ |
|
📌 Commit dafa5a5 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
May 11, 2017
Add other bitwise ops for bitflag enums Currently, bitflag enums only implement `BitOr`. However, it is fairly common to `&` bitflags, requiring the `BitAnd` trait to be implemented as well. I also implemented `BitOrAssign` and `BitAndAssign` in the process.
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, bitflag enums only implement
BitOr. However, it is fairly common to&bitflags, requiring theBitAndtrait to be implemented as well. I also implementedBitOrAssignandBitAndAssignin the process.