Skip to content

ir: Don't assume template instantiation argument with vtable implies vtable #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2017

Conversation

emilio
Copy link
Contributor

@emilio emilio commented May 8, 2017

Fixes #691

@highfive
Copy link

highfive commented May 8, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@emilio
Copy link
Contributor Author

emilio commented May 8, 2017

r? @fitzgen

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen
Copy link
Member

fitzgen commented May 8, 2017

@bors-servo r+

@bors-servo
Copy link

📌 Commit b40f9f0 has been approved by fitzgen

@bors-servo
Copy link

⌛ Testing commit b40f9f0 with merge 2d88dd1...

bors-servo pushed a commit that referenced this pull request May 8, 2017
ir: Don't assume template instantiation argument with vtable implies vtable

Fixes #691
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: fitzgen
Pushing 2d88dd1 to master...

@bors-servo bors-servo merged commit b40f9f0 into rust-lang:master May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants