Add Builder::clang_args (plural) #636
Conversation
src/lib.rs
Outdated
| @@ -555,6 +555,15 @@ impl Builder { | |||
| self | |||
| } | |||
|
|
|||
| /// Add arguments to be passed straight through to clang. | |||
| pub fn clang_args<I>(mut self, iter: I) -> Builder | |||
| where I: IntoIterator, I::Item: AsRef<str> { | |||
There was a problem hiding this comment.
Can we use the format specified in rustfmt.toml?
That is:
pub fn clang_args<I>(mut self, iter: I) -> Builder
where I: IntoIterator,
I::Item: AsRef<str>,
{
// ...
}
src/lib.rs
Outdated
| pub fn clang_args<I>(mut self, iter: I) -> Builder | ||
| where I: IntoIterator, I::Item: AsRef<str> { | ||
| for arg in iter { | ||
| self.options.clang_args.push(arg.as_ref().into()); |
There was a problem hiding this comment.
perhaps:
self = self.clang_arg(arg.as_ref());(not sure if you can assing to self, but perhaps using an intermediate variable is an option?)
That way if we add more stuff to clang_arg we can just keep this. Not a big deal if it's annoying for some reason.
|
Oh, also, you need to update the cargo.lock so travis is happy. |
Use AsRef<str> rather than Into<String> because &&str (what you get when iterating &[&str]) does not implement the latter.
|
☔ The latest upstream changes (presumably c5e044d) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Done both. I was also skeptical about assigning to @bors-servo r=emilio |
|
📌 Commit c5e044d has been approved by |
Add Builder::clang_args (plural) Use `AsRef<str>` rather than `Into<String>` because `&&str` (what you get when iterating `&[&str]`) does not implement the latter.
|
☀️ Test successful - status-travis |
Use
AsRef<str>rather thanInto<String>because&&str(what you get when iterating&[&str]) does not implement the latter.