Handle re-declaration of a global variable. Fix #47 #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanphilippeD
changed the title
Yamakaky
reviewed
Sep 25, 2016
| let name = item.canonical_name(ctx); | ||
| let canonical_name = item.canonical_name(ctx); | ||
|
|
||
| // TODO: Maybe warn here if there's a type mismatch |
There was a problem hiding this comment.
Clang already does it, I think
There was a problem hiding this comment.
Thank you for your comment.
Do you mean the TODO is not necessary?
I guess it would result in a compile error in the C or C++ code.
There was a problem hiding this comment.
Yeah, from what I remember bindgen prints clang warnings, so there is no need to do an other warning
|
Looks great, thanks! @bors-servo: r+ |
|
📌 Commit 8b41159 has been approved by |
|
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Sep 26, 2016
Handle re-declaration of a global variable. Fix #47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.