Add a Stylo bindings sanity test #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fitzgen
force-pushed
the
sanity-test-stylo
branch
from
f0ce76f to
4548bc6
Compare
emilio
approved these changes
Apr 11, 2017
This commit adds a sanity test that we can generate bindings for Stylo without any errors. I tried to make this a `#[bench]` but each iteration takes 36 seconds on my machine, which made the `#[bench]` take *way* too long. Instead, there is a commented out `panic!` that can be uncommented to get a log of how long it took.
fitzgen
force-pushed
the
sanity-test-stylo
branch
from
4548bc6 to
aaaa08a
Compare
Done! Thanks for the review :) @bors-servo r+ |
|
📌 Commit aaaa08a has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Apr 12, 2017
Add a Stylo bindings sanity test This commit adds a sanity test that we can generate bindings for Stylo without any errors. I tried to make this a `#[bench]` but each iteration takes 36 seconds on my machine, which made the `#[bench]` take *way* too long. Instead, there is a commented out `panic!` that can be uncommented to get a log of how long it took. r? @emilio
|
@bors-servo r- |
|
@bors-servo r=emilio |
|
📌 Commit aaaa08a has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Apr 12, 2017
Add a Stylo bindings sanity test This commit adds a sanity test that we can generate bindings for Stylo without any errors. I tried to make this a `#[bench]` but each iteration takes 36 seconds on my machine, which made the `#[bench]` take *way* too long. Instead, there is a commented out `panic!` that can be uncommented to get a log of how long it took. r? @emilio
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a sanity test that we can generate bindings for Stylo without
any errors. I tried to make this a
#[bench]but each iteration takes 36seconds on my machine, which made the
#[bench]take way too long. Instead,there is a commented out
panic!that can be uncommented to get a log of howlong it took.
r? @emilio