Extra assertions and cargo features #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that all of the cargo features we have that only exist for CI/testing purposes, and aren't for external consumption, have a "testing_only_" prefix.
emilio
reviewed
Apr 7, 2017
src/codegen/mod.rs
Outdated
| current_bitfield_layout.is_some()); | ||
| debug_assert_eq!(current_bitfield_width.is_some(), | ||
| extra_assert_eq!(current_bitfield_width.is_some(), |
There was a problem hiding this comment.
I'd prefer to keep the cheap ones debug_assert_eq!s, etc, wdyt?
I believe this could hide real bugs.
This commit defines a new set of assertion macros that are only checked in testing/CI when the `testing_only_extra_assertions` feature is enabled. This makes it so that *users* of bindgen that happen to be making a debug build don't enable all these extra and expensive assertions. Additionally, this removes the `testing_only_assert_no_dangling_items` feature, and runs the assertions that were previously gated on that feature when the new `testing_only_extra_assertions` feature is enabled.
fitzgen
force-pushed
the
extra-assertions
branch
from
2e14b19 to
5004ed4
Compare
|
@emilio I went over each assertion, and if it was trivial, I left it as a |
|
Looks great, thanks! @bors-servo r+ |
|
📌 Commit 5004ed4 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Apr 7, 2017
Extra assertions and cargo features * Clean up testing-only cargo features This commit ensures that all of the cargo features we have that only exist for CI/testing purposes, and aren't for external consumption, have a "testing_only_" prefix. * Define extra assertion macros This commit defines a new set of assertion macros that are only checked in testing/CI when the `testing_only_extra_assertions` feature is enabled. This makes it so that *users* of bindgen that happen to be making a debug build don't enable all these extra and expensive assertions. Additionally, this removes the `testing_only_assert_no_dangling_items` feature, and runs the assertions that were previously gated on that feature when the new `testing_only_extra_assertions` feature is enabled. r? @emilio
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up testing-only cargo features
This commit ensures that all of the cargo features we have that only exist for
CI/testing purposes, and aren't for external consumption, have a "testing_only_"
prefix.
Define extra assertion macros
This commit defines a new set of assertion macros that are only checked in
testing/CI when the
testing_only_extra_assertionsfeature is enabled. Thismakes it so that users of bindgen that happen to be making a debug build don't
enable all these extra and expensive assertions.
Additionally, this removes the
testing_only_assert_no_dangling_itemsfeature,and runs the assertions that were previously gated on that feature when the new
testing_only_extra_assertionsfeature is enabled.r? @emilio