Skip to content

clang: Fix most of the clang 5.0 regressions in our tests. #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2017
Merged

clang: Fix most of the clang 5.0 regressions in our tests. #602

merged 1 commit into from
Mar 30, 2017

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Mar 27, 2017

Still a lot to be sorted out though.

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@emilio
Copy link
Contributor Author

emilio commented Mar 27, 2017

r? @fitzgen or @upsuper

@fitzgen
Copy link
Member

fitzgen commented Mar 27, 2017

r=me when this is passing CI

@fitzgen
Copy link
Member

fitzgen commented Mar 27, 2017

Also, thanks for looking into this!

@emilio emilio force-pushed the clang-5 branch 2 times, most recently from 984b44f to a4fc5e1 Compare March 30, 2017 21:01
@emilio
Copy link
Contributor Author

emilio commented Mar 30, 2017

@bors-servo r=fitzgen

@emilio
Copy link
Contributor Author

emilio commented Mar 30, 2017

Try is green, but homu is dead.

@emilio emilio merged commit d2af109 into rust-lang:master Mar 30, 2017
@emilio emilio deleted the clang-5 branch March 30, 2017 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilio @highfive @fitzgen