Add a Builder::header_contents method to allow passing source code as a string to a Builder
#601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
reviewed
Mar 27, 2017
| @@ -175,6 +175,12 @@ impl Builder { | |||
| self | |||
| } | |||
|
|
|||
| /// Add `contents` as an input C/C++ header named `name`. | |||
There was a problem hiding this comment.
Perhaps note that the files are automatically added to the clang flags?
tests/tests.rs
Outdated
| @@ -32,6 +32,7 @@ fn compare_generated_header(header: &PathBuf, | |||
| Err(_) => "".to_string(), | |||
| }; | |||
|
|
|||
|
|
|||
|
Fixed those nits, thanks for the quick review! |
emilio
approved these changes
Mar 27, 2017
src/clang.rs
Outdated
| @@ -1409,7 +1409,7 @@ impl Drop for Diagnostic { | |||
| /// A file which has not been saved to disk. | |||
| pub struct UnsavedFile { | |||
| x: CXUnsavedFile, | |||
| name: CString, | |||
| pub name: CString, | |||
There was a problem hiding this comment.
CI is failing because this field is public but it's not documented. Please add a line like:
/// The name of the unsaved file. We carry that over to avoid leaving dangling pointers in `CXUnsavedFile`
Or something like that.
…as a string to a Builder Currently the Builder API requires input as header files on disk. This allows passing C source directly to clang using the existing UnsavedFile struct.
|
@bors-servo r+ Thanks again! |
|
📌 Commit 63de948 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Mar 27, 2017
Add a `Builder::header_contents` method to allow passing source code as a string to a Builder Currently the Builder API requires input as header files on disk. This allows passing C source directly to clang using the existing UnsavedFile struct. I'm going to take a shot at implementing a webapp that lets users paste in C source and get the bindgen output. It would make life easier if I didn't have to write the source out to a temp file. This patch allows passing the source in as a `&str`. I wasn't quite sure where to put the new test, but it seems to work in tests.rs.
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Builder API requires input as header files on disk. This allows
passing C source directly to clang using the existing UnsavedFile struct.
I'm going to take a shot at implementing a webapp that lets users paste in C source and get the bindgen output. It would make life easier if I didn't have to write the source out to a temp file. This patch allows passing the source in as a
&str.I wasn't quite sure where to put the new test, but it seems to work in tests.rs.