Run tests with more versions of libclang #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r=me if it passes |
fitzgen
force-pushed
the
more-clang-version-testing
branch
from
50fdafe to
30edebe
Compare
|
Looks like the issue from #585 is in clang 4.0 too: -pub type IntPoint = PointTyped<f32>;
+pub type IntPoint = PointTyped; |
|
And it looks like we need to ignore clang's mangled symbols for non-C++ stuff in 3.7.X: ---- header_decl_ptr_to_array_h stdout ----
diff expected generated
--- expected: "/home/travis/build/servo/rust-bindgen/tests/expectations/tests/decl_ptr_to_array.rs"
+++ generated from: "/home/travis/build/servo/rust-bindgen/tests/headers/decl_ptr_to_array.h"
/* automatically generated by rust-bindgen */
#![allow(non_snake_case)]
extern "C" {
- #[link_name = "foo"]
+ #[link_name = "_Z3foo"]
pub static mut foo: *mut [::std::os::raw::c_int; 1usize];
}
thread 'header_decl_ptr_to_array_h' panicked at 'Header and binding differ!', /tmp/bindgen/debug/build/bindgen-d3df86004a58a8a1/out/tests.rs:50 |
|
I'm going to |
First, update our existing 3.8.X and 3.9.X libclang testing versions to their latest point releases. Second, add testing on the latest 3.7.X release and the latest 4.0.X release.
fitzgen
force-pushed
the
more-clang-version-testing
branch
from
30edebe to
b58c3e0
Compare
|
@bors-servo r=emilio |
|
📌 Commit b58c3e0 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Mar 16, 2017
Run tests with more versions of libclang First, update our existing 3.8.X and 3.9.X libclang testing versions to their latest point releases. Second, add testing on the latest 3.7.X release and the latest 4.0.X release. r? @emilio
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, update our existing 3.8.X and 3.9.X libclang testing versions to their latest point releases. Second, add testing on the latest 3.7.X release and the latest 4.0.X release.
r? @emilio