Do not print builtin macro definitions in ast_dump #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issue rust-lang#476. Moves out logic for checking whether a cursor has a filename (previously used exclusively in private function lib::filter_builtins) into the actual cursor. This code is then used to check whether a cursor is a builtin when dumping the AST.
emilio
approved these changes
Mar 8, 2017
src/clang.rs
Outdated
| /// Returns whether the cursor refers to a built-in definition. | ||
| pub fn is_builtin(&self) -> bool { | ||
| let (file, _, _, _) = self.location().location(); | ||
| !file.name().is_some() |
There was a problem hiding this comment.
nit: file.name().is_none() instead.
src/lib.rs
Outdated
| None => ctx.options().builtins, | ||
| Some(..) => true, | ||
| } | ||
| !cursor.is_builtin() || ctx.options().builtins |
There was a problem hiding this comment.
nit: I'd reverse the order here since the second is way less expensive to check.
|
@emilio thanks for the feedback. Latest commit should address those two points. |
|
@bors-servo r=emilio,fitzgen Thanks @tsliang ! |
|
📌 Commit b826a80 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Mar 9, 2017
Do not print builtin macro definitions in ast_dump Resolves issue #476. Moves out logic for checking whether a cursor has a filename (previously used exclusively in private function lib::filter_builtins) into the actual cursor. This code is then used to check whether a cursor is a builtin when dumping the AST.
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #476. Moves out logic for checking whether a cursor has a filename (previously used exclusively in private function lib::filter_builtins) into the actual cursor. This code is then used to check whether a cursor is a builtin when dumping the AST.