Skip to content

codegen: Don't pad union fields. #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2017
Merged

codegen: Don't pad union fields. #554

merged 1 commit into from
Mar 3, 2017

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Mar 3, 2017

Fixes #553

@emilio emilio mentioned this pull request Mar 3, 2017
Closed
@emilio
Copy link
Contributor Author

emilio commented Mar 3, 2017

r? @fitzgen

fitzgen
fitzgen approved these changes Mar 3, 2017
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@fitzgen
Copy link
Member

fitzgen commented Mar 3, 2017

@bors-servo r+

@bors-servo
Copy link

📌 Commit 0e76c8c has been approved by fitzgen

@bors-servo
Copy link

⌛ Testing commit 0e76c8c with merge b71c7ba...

bors-servo pushed a commit that referenced this pull request Mar 3, 2017
Auto merge of #554 - emilio:union-pad, r=fitzgen
b71c7ba 
codegen: Don't pad union fields.

Fixes #553
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: fitzgen
Pushing b71c7ba to master...

@bors-servo bors-servo merged commit 0e76c8c into rust-lang:master Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emilio @fitzgen @bors-servo @highfive