codegen: Don't assume unsized structs have address. #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dushistov
reviewed
Mar 3, 2017
src/codegen/mod.rs
Outdated
| fields.push(field); | ||
| let has_address = match layout { | ||
| Some(l) => l.size != 0, | ||
| None => true, |
There was a problem hiding this comment.
Little shorter variant: layout.map_or(true, |l| l.size != 0)
fitzgen
approved these changes
Mar 3, 2017
src/codegen/mod.rs
Outdated
| fields.push(field); | ||
| let has_address = match layout { | ||
| Some(l) => l.size != 0, | ||
| None => true, |
| @@ -0,0 +1 @@ | |||
| struct Foo {}; | |||
There was a problem hiding this comment.
I know we have tests for this intermingled here and there elsewhere, but it would be nice to have a C++ companion for this test that has the same contents but with a .hpp extension.
Per C semantics, they may not.
|
@bors-servo r=fitzgen |
|
📌 Commit 5982cd3 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Mar 6, 2017
codegen: Don't assume unsized structs have address. Per C semantics, they may not. r? @fitzgen
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per C semantics, they may not.
r? @fitzgen