Skip to content

Deduplicate names of virtual overloaded methods. Fix #48 #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2016

Conversation

SimonSapin
Copy link
Contributor

r? @emilio

@highfive
Copy link

highfive commented Sep 1, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @emilio (or someone else) soon.

@highfive
Copy link

highfive commented Sep 1, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@emilio
Copy link
Contributor

emilio commented Sep 1, 2016

@bors-servo: r+

@bors-servo
Copy link

📌 Commit 5210a9f has been approved by emilio

@bors-servo
Copy link

⌛ Testing commit 5210a9f with merge 89e2725...

bors-servo pushed a commit that referenced this pull request Sep 1, 2016
Deduplicate names of virtual overloaded methods. Fix #48

r? @emilio
@bors-servo
Copy link

☀️ Test successful - status-travis

@bors-servo bors-servo merged commit 5210a9f into master Sep 1, 2016
SimonSapin added a commit to SimonSapin/teensy-clock that referenced this pull request Sep 3, 2016
@fitzgen fitzgen deleted the dedup-virtual-overloaded-names branch July 20, 2017 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants