Use the constness of the inner type when converting array function args. #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction arguments. Fixes rust-lang#509 I'm actually surprised we had no tests for this. Signed-off-by: Emilio Cobos Álvarez <[email protected]>
|
r? @fitzgen |
fitzgen
approved these changes
Feb 14, 2017
| @@ -2828,7 +2828,7 @@ mod utils { | |||
| // [1]: http://c0x.coding-guidelines.com/6.7.5.3.html | |||
| let arg_ty = match *arg_ty.canonical_type(ctx).kind() { | |||
| TypeKind::Array(t, _) => { | |||
| t.to_rust_ty(ctx).to_ptr(arg_ty.is_const(), ctx.span()) | |||
| t.to_rust_ty(ctx).to_ptr(ctx.resolve_type(t).is_const(), ctx.span()) | |||
|
@bors-servo r+ |
|
@bors-servo r=fitzgen |
|
📌 Commit af6d59c has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Feb 14, 2017
Use the constness of the inner type when converting array function args. Fixes #509 I'm actually surprised we had no tests for this.
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #509
I'm actually surprised we had no tests for this.