Rename llvm_stable feature and remove references from docs. #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Taking a look now :) |
fitzgen
approved these changes
Feb 9, 2017
bindgen-integration/Cargo.toml
Outdated
| @@ -11,4 +11,4 @@ bindgen = { path = ".." } | |||
| gcc = "0.3" | |||
|
|
|||
| [features] | |||
| llvm_stable = ["bindgen/llvm_stable"] | |||
| __testing_only_llvm_stable = ["bindgen/__testing_only_llvm_stable"] | |||
There was a problem hiding this comment.
IIRC, cargo had issues with _ prefixed features, so we may need to change this to simply testing_only_llvm_stable. We'll see when travis CI results get in :)
CONTRIBUTING.md
Outdated
| @@ -90,7 +90,7 @@ Run `cargo test` to compare generated Rust bindings to the expectations. | |||
| ### Running All Tests | |||
|
|
|||
| ``` | |||
| $ cargo test [--features llvm_stable] | |||
| $ cargo test --all-features | |||
fitzgen
reviewed
Feb 9, 2017
| @@ -69,7 +69,7 @@ that you aren't forgetting to document types and functions. CI will catch it if | |||
| you forget, but the turn around will be a lot slower ;) | |||
|
|
|||
| ``` | |||
| $ cargo build --features "llvm_stable _docs" | |||
| $ cargo build --features docs_ | |||
There was a problem hiding this comment.
Yeah the trailing _ was because leading ones weren't properly handled. Perhaps this should be testing_only_docs too?
|
Ping me after removing leading underscores and I'll r+ Thanks again! |
|
Removed the leading underscores, now the build will tell. |
|
Thanks! @bors-servo r+ |
|
📌 Commit 0db962b has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Feb 10, 2017
Rename llvm_stable feature and remove references from docs. Fixes: #409
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #409