check layout align before padding bytes #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo r+ |
|
📌 Commit e08072a has been approved by |
|
Thanks again for digging into this :) |
emilio
reviewed
Feb 8, 2017
|
|
||
| union __ulx{__long __lx; __short __lxx;}; | ||
|
|
||
| enum {__n_words = sizeof(__ulx) / sizeof(size_type)}; |
There was a problem hiding this comment.
wow, this is why we can't have nice things :(
Thanks for finding this out!
bors-servo
pushed a commit
that referenced
this pull request
Feb 8, 2017
check layout align before padding bytes Fix issue #493 again :S Still finding way to reproduce it
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #493 again :S
Still finding way to reproduce it