codegen: Improve the assertion message of failing layout tests. #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, @flier, wanna review this? :) |
fitzgen
approved these changes
Feb 7, 2017
| @@ -2745,7 +2745,7 @@ mod utils { | |||
| } | |||
|
|
|||
| pub fn fnsig_return_ty(ctx: &BindgenContext, | |||
| sig: &super::FunctionSig) | |||
| sig: &FunctionSig) | |||
There was a problem hiding this comment.
If we are going to support older rustc, we should add the oldest supported version to our travis ci matrix.
There was a problem hiding this comment.
This is only temporary until Gecko updates is rustc version anyway, should be <1week
|
@bors-servo r=fitzgen |
|
📌 Commit 193a103 has been approved by |
flier
approved these changes
Feb 8, 2017
| assert_eq!($size_of_expr, $size, | ||
| concat!("Size of template specialization: ", stringify!($ident))); | ||
| assert_eq!($align_of_expr, $align, | ||
| concat!("Alignment of template specialization: ", stringify!($ident))); | ||
| }) |
There was a problem hiding this comment.
The patch is good to me, something else observed.
Do we need check the field offset for the template specialization?
It seems be different to VTable case, should have potential layout issue. Anyway, I haven't user cases in wild
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @fitzgen
cc @flier