Skip to content

Assert that code is properly rustfmted in CI #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 4, 2017

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Feb 3, 2017

r? @emilio

This commit makes Travis CI reject code which has not been run through the
latest version of `rustfmt`.

Additionally, it refactors our CI testing out into a couple little scripts.
@highfive
Copy link

highfive commented Feb 3, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@emilio
Copy link
Contributor

emilio commented Feb 3, 2017

r=me when needed, thanks for this! Maybe worth a note in the CONTRIBUTING file?

@fitzgen
Copy link
Member Author

fitzgen commented Feb 3, 2017

@bors-servo r=emilio

Maybe worth a note in the CONTRIBUTING file?

Done! Thanks!

@bors-servo
Copy link

📌 Commit 50dc792 has been approved by emilio

@bors-servo
Copy link

⌛ Testing commit 50dc792 with merge a3de3fc...

bors-servo pushed a commit that referenced this pull request Feb 4, 2017
Assert that code is properly `rustfmt`ed in CI

r? @emilio
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: emilio
Pushing a3de3fc to master...

@bors-servo bors-servo merged commit 50dc792 into rust-lang:master Feb 4, 2017
@fitzgen fitzgen deleted the fmt-in-ci branch February 6, 2017 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants