Append the input header to the end of the clang args, instead of the front #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo: r+ |
|
📌 Commit 82b166d has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 30, 2016
Append the input header to the end of the clang args, instead of the front r @emilio
|
☀️ Test successful - status-travis |
|
This causes clang to complain with |
Manishearth
added a commit
to Manishearth/servo
that referenced
this pull request
Aug 31, 2016
With what command? I verified manually that the |
|
Yes, that's correct. What Stylo was doing (to workaround the behavior before this patch), was using the filename after clang-flags. I think this confused docopt, that thought that the input header was other thing, and when we pushed it to But it's not this patch's bug per se. |
|
Yes, but stylo binding generation is still broken. What is the fix? |
Manishearth
added a commit
to Manishearth/servo
that referenced
this pull request
Sep 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r @emilio