Use docopt for argument parsing #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit switches bindgen over to using the docopt crate for argument parsing instead of manual argument parsing. This required two notable changes in the arguments and flags style: 1. All flags of the form `-foo` are now of the form `--foo`. 2. We can no longer pass unknown flags straight through to clang. Instead, the user appends `--` after the bindgen flags and input header, after which point any more flags and arguments get collected and passed to clang. This required changes to the test runner and the `// bindgen-flags` comments.
| [dependencies.quasi] | ||
| features = ["with-syntex"] | ||
| version = "0.15" | ||
|
|
There was a problem hiding this comment.
Using cargo add really goes to town with reformatting toml files... I can revert this and add the dependency manually, if you'd prefer.
|
Wohoo, thanks for doing this! :-) I'll merge it, though now I'll have to rebase stuff and change scripts :P @bors-servo: r+ |
|
📌 Commit 1826827 has been approved by |
|
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Aug 27, 2016
Use docopt for argument parsing This commit switches bindgen over to using the docopt crate for argument parsing instead of manual argument parsing. This required two notable changes in the arguments and flags style: 1. All flags of the form `-foo` are now of the form `--foo`. 2. We can no longer pass unknown flags straight through to clang. Instead, the user appends `--` after the bindgen flags and input header, after which point any more flags and arguments get collected and passed to clang. This required changes to the test runner and the `// bindgen-flags` comments. r? @emilio
|
This needs a corresponding PR to the servo side (regen.py), btw |
|
Was the first thing I did a few hours ago: servo/servo#13079 Feel free to review it :P |
|
Thanks for merging :) Will need to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit switches bindgen over to using the docopt crate for argument parsing
instead of manual argument parsing. This required two notable changes in the
arguments and flags style:
-fooare now of the form--foo.user appends
--after the bindgen flags and input header, after which pointany more flags and arguments get collected and passed to clang. This required
changes to the test runner and the
// bindgen-flagscomments.r? @emilio