Version bump, ignore expectations' Cargo.lock

[emilio]

r? @fitzgen or @Yamakaky

[fitzgen]

@bors-servo r+

Make sure to push a tag for the version too!

[bors-servo]

📌 Commit e89bcb8 has been approved by fitzgen

[Yamakaky]

Where can I see the available bors commands?

[KiChjang]

@Yamakaky build.servo.org/homu, but you need to first have reviewer privileges before you can issue commands to bors-servo. Maybe @emilio can help you with this.

[emilio]

Yeah, usually you do at least a few reviews before getting reviewer privileges though

[bors-servo]

⌛ Testing commit e89bcb8 with merge 7ac7877...

[bors-servo]

💔 Test failed - status-travis

[heycam]

I guess the test jobs fail due to the git diff-index --quiet HEAD command. What's the purpose of that? Given that two commands previously we do a git add -A, and add changes to the index, it seems like this will always report that there is a difference between HEAD and the index and return with exit code 1.

[fitzgen]

I guess the test jobs fail due to the git diff-index --quiet HEAD command. What's the purpose of that? Given that two commands previously we do a git add -A, and add changes to the index, it seems like this will always report that there is a difference between HEAD and the index and return with exit code 1.

This is to check that regenerating the test expectations does not introduce any unexpected changes. The git add -A shouldn't result in anything getting added because there shouldn't be any changes. The diff exits non-zero if there are any changes.

As for why changes seem to be added here, I am not sure. Let me take a look.

[fitzgen]

Hmmm... because we pass --quiet there isn't much to investigate :-/

[heycam]

The git diff @ command right before it and the git diff-index HEAD should be looking at the same differences, shouldn't they?

[emilio]

Yup, just forgot to build after the version bump, so the cargo.lock needed to be updated.

@bors-servo r=fitzgen

[bors-servo]

📌 Commit bb63f32 has been approved by fitzgen

[bors-servo]

⌛ Testing commit bb63f32 with merge 146df32...

[bors-servo]

☀️ Test successful - status-travis